linux-kernel - Re: [PATCH] fs/cifs/cifs_dfs_ref.c: fix potential memory leakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130122203603.1bd26363@corrin.poochiereds.net>
Date:	Tue, 22 Jan 2013 20:36:03 -0500
From:	Jeff Layton <jlayton@...hat.com>
To:	Cong Ding <dinggnu@...il.com>
Cc:	Steve French <sfrench@...ba.org>, linux-cifs@...r.kernel.org,
	samba-technical@...ts.samba.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/cifs/cifs_dfs_ref.c: fix potential memory leakage

On Tue, 22 Jan 2013 19:20:58 -0500
Cong Ding <dinggnu@...il.com> wrote:

> When it goes to error through line 144, the memory allocated to *devname is
> not freed, and the caller doesn't free it either in line 250. So we free the
> memroy of *devname in function cifs_compose_mount_options() when it goes to
> error.
> 
> Signed-off-by: Cong Ding <dinggnu@...il.com>
> ---
>  fs/cifs/cifs_dfs_ref.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/cifs/cifs_dfs_ref.c b/fs/cifs/cifs_dfs_ref.c
> index ce5cbd7..210fce2 100644
> --- a/fs/cifs/cifs_dfs_ref.c
> +++ b/fs/cifs/cifs_dfs_ref.c
> @@ -226,6 +226,8 @@ compose_mount_options_out:
>  compose_mount_options_err:
>  	kfree(mountdata);
>  	mountdata = ERR_PTR(rc);
> +	kfree(*devname);
> +	*devname = NULL;
>  	goto compose_mount_options_out;
>  }
>  

Nice catch. Looks correct to me. Should this also go to stable?

Reviewed-by: Jeff Layton <jlayton@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/