linux-kernel - Re: [PATCH 1/1 V2] AMD Family15h Model10-1Fh erratum 746 Workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130123182352.GD4256@pd.tnic>
Date:	Wed, 23 Jan 2013 19:23:52 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	suravee.suthikulpanit@....com
Cc:	iommu@...ts.linux-foundation.org, joro@...tes.org,
	linux-kernel@...r.kernel.org, udovdh@...all.nl,
	ssg.sos.patches@...txmail.amd.com
Subject: Re: [PATCH 1/1 V2] AMD Family15h Model10-1Fh erratum 746 Workaround

On Wed, Jan 23, 2013 at 12:13:28PM -0600, suravee.suthikulpanit@....com wrote:
> From: Suravee Suthikulpanit <suravee.suthikulpanit@....com>
> 
> Changes from V1:
> * Fix logic that check the processor model.
> * Clear writing enable bit after apply the workaround
> * Change function name

You need a proper commit message...

> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@....com>
> 
> diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
> index 81837b0..a04b20a 100644
> --- a/drivers/iommu/amd_iommu_init.c
> +++ b/drivers/iommu/amd_iommu_init.c
> @@ -975,6 +975,37 @@ static void __init free_iommu_all(void)
>  }
>  
>  /*
> + * AMD family15h Model 10h-1fh erratum 746 (IOMMU Logging May Stall Translations)
> + * Workaround:
> + *     BIOS should disable L2B micellaneous clock gating by setting
> + *     L2_L2B_CK_GATE_CONTROL[CKGateL2BMiscDisable](D0F2xF4_x90[2]) = 1b
> + */

... like this one, for example. You could explain what the erratum does
and what the workaround is in the commit message.

> +static void __init amd_iommu_erratum_746_workaround(struct amd_iommu *iommu)
> +{
> +	u32 value;
> +
> +	if ((boot_cpu_data.x86 != 0x15) || 
> +	    (boot_cpu_data.x86_model < 0x10) ||
> +	    (boot_cpu_data.x86_model > 0x1f))
> +		return;
> +	
> +	pci_write_config_dword(iommu->dev, 0xf0, 0x90);
> +	pci_read_config_dword(iommu->dev, 0xf4, &value); 
> +
> +	if (!(value & 0x4)) {

Save an indentation level by reversing the logic here:

	if (value & BIT(2))
		return;

	/* Select NB...

> +		/* Select Northbridge indirect register 0x90 and enable writing */
> +		pci_write_config_dword(iommu->dev, 0xf0, 0x90 | (1 << 8));
> +
> +		pci_write_config_dword(iommu->dev, 0xf4, value | 0x4);
> +		pr_info("AMD-Vi: Applying erratum 746 workaround for IOMMU at %s\n",
> +		 dev_name(&iommu->dev->dev));
> +
> +		/* Clear the enable writing bit */
> +		pci_write_config_dword(iommu->dev, 0xf0, 0x90);
> +	}
> +}
> +
> +/*
>   * This function clues the initialization function for one IOMMU
>   * together and also allocates the command buffer and programs the
>   * hardware. It does NOT enable the IOMMU. This is done afterwards.
> @@ -1171,6 +1202,8 @@ static int iommu_init_pci(struct amd_iommu *iommu)
>  		for (i = 0; i < 0x83; i++)
>  			iommu->stored_l2[i] = iommu_read_l2(iommu, i);
>  	}
> +	
> +	amd_iommu_erratum_746_workaround(iommu);
>  
>  	return pci_enable_device(iommu->dev);

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/