| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CABVzNXq=LB87+oSvMo=TLumS6M6qnaA+Wtg5TRO+banNbo9-iw@mail.gmail.com> Date: Wed, 23 Jan 2013 11:31:08 -0700 From: Hakan Akkan <hakanakkan@...il.com> To: Frederic Weisbecker <fweisbec@...il.com> Cc: LKML <linux-kernel@...r.kernel.org>, Alessio Igor Bogani <abogani@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, Chris Metcalf <cmetcalf@...era.com>, Christoph Lameter <cl@...ux.com>, Geoff Levand <geoff@...radead.org>, Gilad Ben Yossef <gilad@...yossef.com>, Ingo Molnar <mingo@...nel.org>, Li Zhong <zhong@...ux.vnet.ibm.com>, Namhyung Kim <namhyung.kim@....com>, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, Paul Gortmaker <paul.gortmaker@...driver.com>, Peter Zijlstra <peterz@...radead.org>, Steven Rostedt <rostedt@...dmis.org>, Thomas Gleixner <tglx@...utronix.de> Subject: Re: [ANNOUNCE] 3.8-rc4-nohz3 Hi, This WARN_ON is triggered for every full nohz CPU in the system during AP boot in a 16 core machine: [ 0.336895] ------------[ cut here ]------------ [ 0.341508] WARNING: at arch/x86/kernel/smp.c:123 native_smp_send_reschedule+0x4f/0x60() [ 0.349578] Hardware name: X8DTG-D [ 0.315066] smpboot: Booting Node 0, Processors #1 [ 0.352978] Modules linked in: [ 0.356233] Pid: 0, comm: swapper/1 Not tainted 3.8.0-rc4+ #3 [ 0.361959] Call Trace: [ 0.364404] [<ffffffff8103c4fa>] warn_slowpath_common+0x7a/0xb0 [ 0.370399] [<ffffffff8103c545>] warn_slowpath_null+0x15/0x20 [ 0.376213] [<ffffffff8102435f>] native_smp_send_reschedule+0x4f/0x60 [ 0.382723] [<ffffffff8106b328>] wake_up_nohz_cpu+0x78/0x80 [ 0.388374] [<ffffffff8104c33a>] add_timer_on+0x8a/0xf0 [ 0.393679] [<ffffffff8101c6f4>] mce_start_timer+0x64/0x70 [ 0.399241] [<ffffffff8101c752>] __mcheck_cpu_init_timer+0x52/0x60 [ 0.405490] [<ffffffff817d804a>] mcheck_cpu_init+0x360/0x3d9 [ 0.411226] [<ffffffff817d6160>] identify_cpu+0x39d/0x3ba [ 0.416696] [<ffffffff817d6193>] identify_secondary_cpu+0x16/0x1d [ 0.422855] [<ffffffff817d9730>] smp_store_cpu_info+0x38/0x3a [ 0.428672] [<ffffffff817d981a>] start_secondary+0xe8/0x192 [ 0.434317] ---[ end trace 17bfa0d8291c432e ]--- The machine seems to be working just fine. FYI. On Tue, Jan 22, 2013 at 5:34 PM, Frederic Weisbecker <fweisbec@...il.com> wrote: > Hi, > > This version of the full dynticks patchset integrates the latest full > dynticks cputime accounting changes (see https://lkml.org/lkml/2013/1/22/652) > and is rebased against 3.8-rc4. > > All of these patches have been posted already so I'm not spamming > you again. > > You can pull from: > > git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git > 3.8-rc4-nohz3 > > So this fixes and improve a lot of things since 3.8-rc2-nohz2: > > - Use sched_clock() instead of jiffies for better precision. And because > jiffies granularity was requiring too much dirty hacks to make it working. > (Thanks Steven for the suggestion). > > - To fully support sched_clock(), use a per nanosec granularity in cputime_t > > - Fix a deadlock with tsacct > > - Better description of the Kconfig > > - Don't scale generic vtime accounting against CFS precise task time accounting. > Now that we use sched_clock() we should have precise enough statistics. > > - Consolidate some code in the reader side > > - Make the reader irqsafe (fix potential deadlock against writers) > > - Handle guest cputime > > - Handle idle tasks. Those were special because they don't start from schedule() > so they need their own initializations. > > - Fix build error with CONFIG_IRQ_TIME_ACCOUNTING (thanks Wu Fenguang) > > - Depend on 64 bits archs to make kernel_cpustat reading to be atomic > > > Thanks. > > --- > Frederic Weisbecker (44): > irq_work: Fix racy IRQ_WORK_BUSY flag setting > irq_work: Fix racy check on work pending flag > irq_work: Remove CONFIG_HAVE_IRQ_WORK > nohz: Add API to check tick state > irq_work: Don't stop the tick with pending works > irq_work: Make self-IPIs optable > printk: Wake up klogd using irq_work > context_tracking: Add comments on interface and internals > context_tracking: Export context state for generic vtime > cputime: Librarize per nsecs resolution cputime definitions > cputime: Move default nsecs_to_cputime() to jiffies based cputime file > cputime: Generic on-demand virtual cputime accounting > cputime: Allow dynamic switch between tick/virtual based cputime accounting > cputime: Use accessors to read task cputime stats > kvm: Prepare to add generic guest entry/exit callbacks > cputime: Safely read cputime of full dynticks CPUs > Merge branch 'nohz/printk-v8' > nohz: Basic full dynticks interface > nohz: Assign timekeeping duty to a non-full-nohz CPU > nohz: Trace timekeeping update > nohz: Wake up full dynticks CPUs when a timer gets enqueued > rcu: Restart the tick on non-responding full dynticks CPUs > sched: Comment on rq->clock correctness in ttwu_do_wakeup() in nohz > sched: Update rq clock on nohz CPU before migrating tasks > sched: Update rq clock on nohz CPU before setting fair group shares > sched: Update rq clock on tickless CPUs before calling check_preempt_curr() > sched: Update rq clock earlier in unthrottle_cfs_rq > sched: Update clock of nohz busiest rq before balancing > sched: Update rq clock before idle balancing > sched: Update nohz rq clock before searching busiest group on load balancing > nohz: Move nohz load balancer selection into idle logic > nohz: Full dynticks mode > nohz: Only stop the tick on RCU nocb CPUs > nohz: Don't turn off the tick if rcu needs it > nohz: Don't stop the tick if posix cpu timers are running > nohz: Add some tracing > rcu: Don't keep the tick for RCU while in userspace > profiling: Remove unused timer hook > timer: Don't run non-pinned timer to full dynticks CPUs > sched: Use an accessor to read rq clock > sched: Debug nohz rq clock > sched: Remove broken check for skip clock update > sched: Update rq clock before rt sched average scale > sched: Disable lb_bias feature for full dynticks > > Steven Rostedt (2): > irq_work: Flush work on CPU_DYING > irq_work: Warn if there's still work on cpu_down > > arch/alpha/Kconfig | 1 - > arch/alpha/kernel/osf_sys.c | 6 +- > arch/arm/Kconfig | 1 - > arch/arm64/Kconfig | 1 - > arch/blackfin/Kconfig | 1 - > arch/frv/Kconfig | 1 - > arch/hexagon/Kconfig | 1 - > arch/ia64/include/asm/cputime.h | 92 +-------- > arch/ia64/include/asm/thread_info.h | 4 +- > arch/ia64/include/asm/xen/minstate.h | 2 +- > arch/ia64/kernel/asm-offsets.c | 2 +- > arch/ia64/kernel/entry.S | 16 +- > arch/ia64/kernel/fsys.S | 4 +- > arch/ia64/kernel/head.S | 4 +- > arch/ia64/kernel/ivt.S | 8 +- > arch/ia64/kernel/minstate.h | 2 +- > arch/ia64/kernel/time.c | 4 +- > arch/mips/Kconfig | 1 - > arch/parisc/Kconfig | 1 - > arch/powerpc/Kconfig | 1 - > arch/powerpc/configs/chroma_defconfig | 2 +- > arch/powerpc/configs/corenet64_smp_defconfig | 2 +- > arch/powerpc/configs/pasemi_defconfig | 2 +- > arch/powerpc/include/asm/cputime.h | 6 +- > arch/powerpc/include/asm/lppaca.h | 2 +- > arch/powerpc/include/asm/ppc_asm.h | 4 +- > arch/powerpc/kernel/entry_64.S | 4 +- > arch/powerpc/kernel/time.c | 4 +- > arch/powerpc/platforms/pseries/dtl.c | 6 +- > arch/powerpc/platforms/pseries/setup.c | 6 +- > arch/s390/Kconfig | 1 - > arch/s390/kernel/vtime.c | 6 +- > arch/sh/Kconfig | 1 - > arch/sparc/Kconfig | 1 - > arch/x86/Kconfig | 1 - > arch/x86/kernel/apm_32.c | 11 +- > drivers/isdn/mISDN/stack.c | 7 +- > drivers/staging/iio/trigger/Kconfig | 1 - > fs/binfmt_elf.c | 8 +- > fs/binfmt_elf_fdpic.c | 7 +- > fs/proc/array.c | 4 +- > include/asm-generic/cputime.h | 66 +----- > include/asm-generic/cputime_jiffies.h | 72 ++++++ > include/asm-generic/cputime_nsecs.h | 104 +++++++++ > include/linux/context_tracking.h | 28 +++ > include/linux/hardirq.h | 4 +- > include/linux/init_task.h | 11 + > include/linux/irq_work.h | 20 ++ > include/linux/kernel_stat.h | 2 +- > include/linux/kvm_host.h | 55 ++++- > include/linux/posix-timers.h | 1 + > include/linux/printk.h | 3 - > include/linux/profile.h | 13 -- > include/linux/rcupdate.h | 8 + > include/linux/sched.h | 50 ++++- > include/linux/tick.h | 26 +++- > include/linux/tsacct_kern.h | 3 + > include/linux/vtime.h | 59 ++++-- > init/Kconfig | 28 ++- > kernel/acct.c | 6 +- > kernel/context_tracking.c | 110 ++++++++--- > kernel/cpu.c | 4 +- > kernel/delayacct.c | 7 +- > kernel/exit.c | 10 +- > kernel/fork.c | 6 + > kernel/hrtimer.c | 3 +- > kernel/irq_work.c | 131 +++++++++--- > kernel/posix-cpu-timers.c | 39 +++- > kernel/printk.c | 36 ++-- > kernel/profile.c | 24 -- > kernel/rcutree.c | 19 ++- > kernel/rcutree.h | 1 - > kernel/rcutree_plugin.h | 13 +- > kernel/sched/core.c | 105 ++++++++- > kernel/sched/cputime.c | 298 +++++++++++++++++++++++--- > kernel/sched/fair.c | 96 ++++++--- > kernel/sched/features.h | 3 + > kernel/sched/rt.c | 8 +- > kernel/sched/sched.h | 50 +++++ > kernel/sched/stats.h | 8 +- > kernel/sched/stop_task.c | 8 +- > kernel/signal.c | 12 +- > kernel/softirq.c | 11 +- > kernel/time/Kconfig | 9 + > kernel/time/tick-broadcast.c | 3 +- > kernel/time/tick-common.c | 5 +- > kernel/time/tick-sched.c | 144 +++++++++++-- > kernel/timer.c | 6 +- > kernel/tsacct.c | 44 +++- > 89 files changed, 1489 insertions(+), 522 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists