[<prev] [next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.00.1301241447420.30690@chino.kir.corp.google.com>
Date: Thu, 24 Jan 2013 14:49:31 -0800 (PST)
From: David Rientjes <rientjes@...gle.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
cc: George Zhang <georgezhang@...are.com>,
Andy king <acking@...are.com>,
Dmitry Torokhov <dtor@...are.com>, linux-kernel@...r.kernel.org
Subject: [patch] drivers, vmci: Fix build error
We can't rely on vmalloc.h being included by other included files because
under some configs it is possible for the build to fail:
drivers/misc/vmw_vmci/vmci_queue_pair.c: In function 'qp_free_queue':
drivers/misc/vmw_vmci/vmci_queue_pair.c:270: error: implicit declaration of function 'vunmap'
drivers/misc/vmw_vmci/vmci_queue_pair.c:277: error: implicit declaration of function 'vfree'
drivers/misc/vmw_vmci/vmci_queue_pair.c: In function 'qp_alloc_queue':
drivers/misc/vmw_vmci/vmci_queue_pair.c:302: error: implicit declaration of function 'vmalloc'
drivers/misc/vmw_vmci/vmci_queue_pair.c:302: warning: assignment makes pointer from integer without a cast
drivers/misc/vmw_vmci/vmci_queue_pair.c:324: error: implicit declaration of function 'vmap'
drivers/misc/vmw_vmci/vmci_queue_pair.c:324: error: 'VM_MAP' undeclared (first use in this function)
drivers/misc/vmw_vmci/vmci_queue_pair.c:324: error: (Each undeclared identifier is reported only once
drivers/misc/vmw_vmci/vmci_queue_pair.c:324: error: for each function it appears in.)
drivers/misc/vmw_vmci/vmci_queue_pair.c: In function 'qp_host_map_queues':
drivers/misc/vmw_vmci/vmci_queue_pair.c:843: error: 'VM_MAP' undeclared (first use in this function)
Fix the build by directly including vmalloc.h.
Signed-off-by: David Rientjes <rientjes@...gle.com>
---
drivers/misc/vmw_vmci/vmci_queue_pair.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c
--- a/drivers/misc/vmw_vmci/vmci_queue_pair.c
+++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c
@@ -25,6 +25,7 @@
#include <linux/slab.h>
#include <linux/socket.h>
#include <linux/wait.h>
+#include <linux/vmalloc.h>
#include "vmci_handle_array.h"
#include "vmci_queue_pair.h"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists