linux-kernel - Re: [PATCH 04/35] x86: Clean up e820 add kernel range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130124232133.GA25969@jshin-Toonie>
Date:	Thu, 24 Jan 2013 17:21:33 -0600
From:	Jacob Shin <jacob.shin@....com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jan Kiszka <jan.kiszka@....de>,
	Jason Wessel <jason.wessel@...driver.com>,
	Borislav Petkov <bp@...en8.de>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 04/35] x86: Clean up e820 add kernel range

On Thu, Jan 24, 2013 at 12:19:45PM -0800, Yinghai Lu wrote:
> Separate it out to another function instead.
> 
> Also add support for case when memmap=xxM$yyM is used without exactmap.
> Need to remove reserved range at first before we add E820_RAM
> range, otherwise added E820_RAM range will be ignored.
> 
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> Cc: Jacob Shin <jacob.shin@....com>

Acked-by: Jacob Shin <jacob.shin@....com>

Thanks,

> ---
>  arch/x86/kernel/setup.c |   36 ++++++++++++++++++++++--------------
>  1 file changed, 22 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index b23362f..2242356 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -702,6 +702,27 @@ static void __init trim_bios_range(void)
>  	sanitize_e820_map(e820.map, ARRAY_SIZE(e820.map), &e820.nr_map);
>  }
>  
> +/* called before trim_bios_range() to spare extra sanitize */
> +static void __init e820_add_kernel_range(void)
> +{
> +	u64 start = __pa_symbol(_text);
> +	u64 size = __pa_symbol(_end) - start;
> +
> +	/*
> +	 * Complain if .text .data and .bss are not marked as E820_RAM and
> +	 * attempt to fix it by adding the range. We may have a confused BIOS,
> +	 * or the user may have used memmap=exactmap or memmap=xxM$yyM to
> +	 * exclude kernel range. If we really are running on top non-RAM,
> +	 * we will crash later anyways.
> +	 */
> +	if (e820_all_mapped(start, start + size, E820_RAM))
> +		return;
> +
> +	pr_warn(".text .data .bss are not marked as E820_RAM!\n");
> +	e820_remove_range(start, size, E820_RAM, 0);
> +	e820_add_region(start, size, E820_RAM);
> +}
> +
>  static int __init parse_reservelow(char *p)
>  {
>  	unsigned long long size;
> @@ -897,20 +918,7 @@ void __init setup_arch(char **cmdline_p)
>  	insert_resource(&iomem_resource, &data_resource);
>  	insert_resource(&iomem_resource, &bss_resource);
>  
> -	/*
> -	 * Complain if .text .data and .bss are not marked as E820_RAM and
> -	 * attempt to fix it by adding the range. We may have a confused BIOS,
> -	 * or the user may have incorrectly supplied it via memmap=exactmap. If
> -	 * we really are running on top non-RAM, we will crash later anyways.
> -	 */
> -	if (!e820_all_mapped(code_resource.start, __pa(__brk_limit), E820_RAM)) {
> -		pr_warn(".text .data .bss are not marked as E820_RAM!\n");
> -
> -		e820_add_region(code_resource.start,
> -				__pa(__brk_limit) - code_resource.start + 1,
> -				E820_RAM);
> -	}
> -
> +	e820_add_kernel_range();
>  	trim_bios_range();
>  #ifdef CONFIG_X86_32
>  	if (ppro_with_ram_bug()) {
> -- 
> 1.7.10.4
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/