linux-kernel - Re: [PATCH] CONFIG_PANIC_ON_OOPS should be shown if DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130124101854.GC27602@gmail.com>
Date:	Thu, 24 Jan 2013 11:18:54 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Kyle McMartin <kyle@...hat.com>, linux-kernel@...r.kernel.org,
	mingo@...hat.com
Subject: Re: [PATCH] CONFIG_PANIC_ON_OOPS should be shown if DEBUG_KERNEL


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Tue, 22 Jan 2013 14:21:03 -0500
> Kyle McMartin <kyle@...hat.com> wrote:
> 
> > CONFIG_EXPERT is a bit silly a place for this, and hides it
> > unnecessarily. CONFIG_DEBUG_KERNEL makes much more sense.
> > 
> > Signed-off-by: Kyle McMartin <kyle@...hat.com>
> > 
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -243,7 +243,7 @@ config BOOTPARAM_SOFTLOCKUP_PANIC_VALUE
> >  	default 1 if BOOTPARAM_SOFTLOCKUP_PANIC
> >  
> >  config PANIC_ON_OOPS
> > -	bool "Panic on Oops" if EXPERT
> > +	bool "Panic on Oops" if DEBUG_KERNEL
> >  	default n
> >  	help
> >  	  Say Y here to enable the kernel to panic when it oopses. This
> 
> hm, I'm not sure that it should depend on anything.  Where's the benefit?

Agreed.

(The 'default n' is superfuous as well, while at it.)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/