linux-kernel - Re: [PATCH v2] sched: Fix print format for u64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130124141930.GA14881@gmail.com>
Date:	Thu, 24 Jan 2013 15:19:30 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Fabio Estevam <festevam@...il.com>
Cc:	mingo@...hat.com, peterz@...radead.org, pjt@...gle.com,
	linux-kernel@...r.kernel.org,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH v2] sched: Fix print format for u64


* Fabio Estevam <festevam@...il.com> wrote:

> Hi Ingo,
> 
> On Tue, Dec 25, 2012 at 9:24 AM, Fabio Estevam <festevam@...il.com> wrote:
> > From: Fabio Estevam <fabio.estevam@...escale.com>
> >
> > commit c566e8e9 (sched: Aggregate total task_group load) introduced the
> > following build warning:
> >
> > kernel/sched/debug.c:225:2: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'u64' [-Wformat]
> > kernel/sched/debug.c:225:2: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'u64' [-Wformat]
> >
> > Use %llu format to print a u64 value as per Documentation/printk-formats.txt.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
> 
> Does this one look good?

I suppose - is this patch warning-free both on 64-bit and 32-bit 
systems?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/