linux-kernel - Re: [PATCH v2] usb: host: tegra: make use of PHY pointer of HCD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH7OJZsL2akgaU5qQo=gykVAcFkYyCbP4f1WuBDePd5o788o4A@mail.gmail.com>
Date:	Thu, 24 Jan 2013 21:28:32 +0530
From:	BVG Rao <venubyravarasu@...il.com>
To:	balbi@...com
Cc:	Venu Byravarasu <vbyravarasu@...dia.com>,
	gregkh@...uxfoundation.org, stern@...land.harvard.edu,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	swarren@...dotorg.org
Subject: Re: [PATCH v2] usb: host: tegra: make use of PHY pointer of HCD

On Thu, Jan 24, 2013 at 7:35 PM, Felipe Balbi <balbi@...com> wrote:
> Hi,
>
> On Thu, Jan 24, 2013 at 03:57:03PM +0530, Venu Byravarasu wrote:
>> As pointer to PHY structure can be stored in struct usb_hcd
>> making use of it, to call Tegra PHY APIs.
>>
>> Call to usb_phy_shutdown() is moved up in tegra_ehci_remove(),
>> so that to avoid dereferencing of hcd after its freed up.
>>
>> Signed-off-by: Venu Byravarasu <vbyravarasu@...dia.com>
>> ---
>> First version of patch can be found at
>> http://marc.info/?l=linux-kernel&m=135581479020213&w=2. As it was not
>> yet applied, sending v2 of the patch.
>>
>> delta from v1:
>> Modified all Tegra PHY APIs to use standard 'structu usb_phy *' as
>> their parameter instead of proprietary parameter of type 'struct tegra_usb_phy *'.
>
> I would like to see those tegra-specific functions vanish from the
> driver. Can that be done for v3.10 merge window ?

Deleting these functions may not be possible because of the way,
Tegra20 USB PHY and controllers are designed.
Hence I'm trying to remove tegra specific structure pointers as
function parameter
and use generic USB PHY structure pointers instead.

>
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/