linux-kernel - Re: [PATCH 6/6] Drivers: hv: Execute shutdown in a thread context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130124171740.GA5420@kroah.com>
Date:	Thu, 24 Jan 2013 09:17:40 -0800
From:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:	KY Srinivasan <kys@...rosoft.com>
Cc:	Jiri Kosina <jkosina@...e.cz>, "olaf@...fle.de" <olaf@...fle.de>,
	"jasowang@...hat.com" <jasowang@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"James.Bottomley@...senPartnership.com" 
	<James.Bottomley@...senPartnership.com>,
	"apw@...onical.com" <apw@...onical.com>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH 6/6] Drivers: hv: Execute shutdown in a thread context

On Thu, Jan 24, 2013 at 05:06:27PM +0000, KY Srinivasan wrote:
> 
> 
> > -----Original Message-----
> > From: Jiri Kosina [mailto:jkosina@...e.cz]
> > Sent: Thursday, January 24, 2013 5:10 AM
> > To: KY Srinivasan
> > Cc: gregkh@...uxfoundation.org; linux-kernel@...r.kernel.org;
> > devel@...uxdriverproject.org; olaf@...fle.de; apw@...onical.com;
> > jasowang@...hat.com; davem@...emloft.net;
> > James.Bottomley@...senPartnership.com
> > Subject: Re: [PATCH 6/6] Drivers: hv: Execute shutdown in a thread context
> > 
> > On Wed, 23 Jan 2013, K. Y. Srinivasan wrote:
> > 
> > > Execute the shutdown code in a thread context. With recent changes made to
> > the
> > > shutdown code, shutdown code cannot be invoked from an interrupt context.
> > >
> > > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> > > Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>
> > > ---
> > >  drivers/hv/hv_util.c |   12 +++++++++++-
> > >  1 files changed, 11 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
> > > index 8b7868a..aceb67f 100644
> > > --- a/drivers/hv/hv_util.c
> > > +++ b/drivers/hv/hv_util.c
> > > @@ -49,6 +49,16 @@ static struct hv_util_service util_kvp = {
> > >  	.util_deinit = hv_kvp_deinit,
> > >  };
> > >
> > > +static void perform_shutdown(struct work_struct *dummy)
> > > +{
> > > +		orderly_poweroff(true);
> > > +}
> > 
> > Is there any particular reason for this kind of crazy indentation?
> I don't know how this extra tab crept through! Greg, if you want I can resend
> this patch minus the extra tab. Let me know.

I'll edit it by hand, but someone owes me a beer for it...  :)

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/