linux-kernel - Re: [PATCH] staging/comedi: Move comedi_pci_auto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201301242230.49732.PeterHuewe@gmx.de>
Date:	Thu, 24 Jan 2013 22:30:49 +0100
From:	Peter Huewe <PeterHuewe@....de>
To:	Ian Abbott <abbotti@....co.uk>
Cc:	Ian Abbott <ian.abbott@....co.uk>,
	Mori Hess <fmhess@...rs.sourceforge.net>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging/comedi: Move comedi_pci_auto_unconfig to drivers.c

Am Donnerstag, 24. Januar 2013, 11:02:35 schrieb Ian Abbott:
> On 2013-01-22 23:03, Peter Huewe wrote:
> > Since comedi_pci_auto_unconfig cannot be inlined anymore after
> > 
> >   staging/comedi: Use comedi_pci_auto_unconfig directly for
> >   pci_driver.remove
> > 
> > is applied, it makes sense to move it drivers.c
> > 
> > Signed-off-by: Peter Huewe <peterhuewe@....de>
> > ---
> > 

> Embarassingly (for me) I submitted a patch to do the exact opposite
> previously, but I've no problem doing it this way if it saves some code.

Hi Ian,
;)

If you think it's cleaner the way it is currently we can leave it like that. 
Especially if you think some driver might actually do something in the remove 
function (in the future).

However if we could also find a way to remove all the probe function stuff as 
well we should remove it.
Most (comedi pci) drivers simply call comedi_pci_auto_config and not much more 
- but I'm currently not sure how to do this ;)

Thanks,
PeterH

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/