linux-kernel - Re: [PATCHv2] tools lib traceevent: Handle dynamic array's element size properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1359063185.21576.157.camel@gandalf.local.home>
Date:	Thu, 24 Jan 2013 16:33:05 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Arnaldo Carvalho de Melo <acme@...hat.com>
Cc:	Jiri Olsa <jolsa@...hat.com>, linux-kernel@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Namhyung Kim <namhyung@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCHv2] tools lib traceevent: Handle dynamic array's element
 size properly

On Thu, 2013-01-24 at 18:28 -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jan 24, 2013 at 04:13:13PM -0500, Steven Rostedt escreveu:
> > On Thu, 2013-01-24 at 21:46 +0100, Jiri Olsa wrote:
> > >  
> > > +static unsigned int type_size(char *name)
> > 
> > Sorry to nitpick, but please make that const char *name.
> 
> Agreed, no need to resubmit, I'll fix that up.

I'm sure Tom St Denis appreciates it.

> 
> > The rest looks good.
> 
> Thanks, adding your Acked-by,

Sure. But I probably should test it too ;-)

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/