linux-kernel - Re: [PATCH] USB: XHCI: fix memory leak of URB-private data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5101AD55.2000008@fold.natur.cuni.cz>
Date:	Thu, 24 Jan 2013 22:53:25 +0100
From:	Martin Mokrejs <mmokrejs@...d.natur.cuni.cz>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>,
	Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] USB: XHCI: fix memory leak of URB-private data

Hi Sarah and Alan,
  I just saw 3.7.5 patches announced by Greg but I don't see this path in there.
And, don't know but maybe this applies to older stable kernels as well?
Where will this patch posted originally to linux-usb land?

Ah, is that because the email was actually NOT sent to "stable@"? ;-)

Date:	Thu, 17 Jan 2013 10:32:16 -0500 (EST)
From: Alan Stern <stern@...land.harvard.edu>
To: Sarah Sharp <sarah.a.sharp@...ux.intel.com>
cc: Martin Mokrejs <mmokrejs@...d.natur.cuni.cz>,
  USB list <linux-usb@...r.kernel.org>
Subject: [PATCH] USB: XHCI: fix memory leak of URB-private data
Message-ID: <Pine.LNX.4.44L0.1301171031260.1339-100000@...anthe.rowland.org>

Thank you,
Martin

Alan Stern wrote:
> This patch (as1640) fixes a memory leak in xhci-hcd.  The urb_priv
> data structure isn't always deallocated in the handle_tx_event()
> routine for non-control transfers.  The patch adds a kfree() call so
> that all paths end up freeing the memory properly.
> 
> Signed-off-by: Alan Stern <stern@...land.harvard.edu>
> Reported-and-tested-by: Martin Mokrejs <mmokrejs@...d.natur.cuni.cz>
> CC: <stable@...r.kernel.org>
> 
> ---
> 
>  drivers/usb/host/xhci-ring.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> Index: usb-3.7/drivers/usb/host/xhci-ring.c
> ===================================================================
> --- usb-3.7.orig/drivers/usb/host/xhci-ring.c
> +++ usb-3.7/drivers/usb/host/xhci-ring.c
> @@ -2580,6 +2580,8 @@ cleanup:
>  				(trb_comp_code != COMP_STALL &&
>  					trb_comp_code != COMP_BABBLE))
>  				xhci_urb_free_priv(xhci, urb_priv);
> +			else
> +				kfree(urb_priv);
>  
>  			usb_hcd_unlink_urb_from_ep(bus_to_hcd(urb->dev->bus), urb);
>  			if ((urb->actual_length != urb->transfer_buffer_length &&
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/