lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Jan 2013 20:55:31 -0800 From: Stephen Warren <swarren@...dia.com> To: Axel Lin <axel.lin@...ics.com> CC: Mark Brown <broonie@...nsource.wolfsonmicro.com>, Gyungoh Yoo <jack.yoo@...im-ic.com>, Laxman Dewangan <ldewangan@...dia.com>, Graeme Gregory <gg@...mlogic.co.uk>, Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/3] regulator: max8907: Fix using wrong dev argument for calling of_regulator_match On 01/24/2013 06:20 PM, Axel Lin wrote: > The dev parameter is the device requesting the data. > In this case it should be &pdev->dev rather than pdev->dev.parent. > > The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(), > which means this fixes a memory leak because the memory is allocated every time > probe() is called, thus it should be freed when this driver is unloaded. Reviewed-by: Stephen Warren <swarren@...dia.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists