[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <9436.1359072427@warthog.procyon.org.uk>
Date: Fri, 25 Jan 2013 00:07:07 +0000
From: David Howells <dhowells@...hat.com>
To: Michal Marek <mmarek@...e.cz>
Cc: dhowells@...hat.com, rusty@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] MODSIGN: Specify the hash algorithm on sign-file command line
Michal Marek <mmarek@...e.cz> wrote:
> >> +our ($opt_v, $opt_a);
> >
> > Should this be 'our' or 'my'?
>
> These are global variables set by getopts(), so they need to be declared
> 'our'. But I can change it to use the two-argument version of getopts,
> that does not use global variables.
No, that's fine. Perl seems like black magic at the best of times.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists