linux-kernel - Re: [PATCH v3 1/4] drivers: usb: phy: add a new driver for usb part of control module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Jan 2013 09:48:18 +0200
From:	Felipe Balbi <balbi@...com>
To:	Stephen Warren <swarren@...dotorg.org>
CC:	Kishon Vijay Abraham I <kishon@...com>, <rob.herring@...xeda.com>,
	<rob@...dley.net>, <tony@...mide.com>, <balbi@...com>,
	<b-cousson@...com>, <linux-usb@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <devicetree-discuss@...ts.ozlabs.org>,
	<gregkh@...uxfoundation.org>, <linux@....linux.org.uk>
Subject: Re: [PATCH v3 1/4] drivers: usb: phy: add a new driver for usb part
 of control module

On Thu, Jan 24, 2013 at 09:32:46PM -0800, Stephen Warren wrote:
> On 01/24/2013 06:19 PM, Kishon Vijay Abraham I wrote:
> > Added a new driver for the usb part of control module. This has an API
> > to power on the USB2 phy and an API to write to the mailbox depending on
> > whether MUSB has to act in host mode or in device mode.
> > 
> > Writing to control module registers for doing the above task which was
> > previously done in omap glue and in omap-usb2 phy will be removed.
> 
> > diff --git a/Documentation/devicetree/bindings/usb/usb-phy.txt b/Documentation/devicetree/bindings/usb/usb-phy.txt
> 
> This file seems to be specific to the TI USB PHYs, not all USB PHYs;
> shouldn't it be renamed ti-usb-phy.txt, or even better renamed to match
> the compatible value it documents, giving ti,omap-usb2.txt?

could be, but that can be done as a separate patch. It's not part of
$SUBJECT.

> >  add the address of control module dev conf register until a driver for
> >  control module is added
> >  
> > +Optional properties:
> > + - ctrl_module : phandle of the control module used by PHY driver to power on
> > +   the PHY.
> 
> DT property names generally use - not _ as the word separator.

fair enough, Kishon, can you fix this up ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)