linux-kernel - Re: [PATCH v2] sched: Fix print format for u64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130125080656.GB25314@gmail.com>
Date:	Fri, 25 Jan 2013 09:06:56 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Paul Turner <pjt@...gle.com>
Cc:	Fabio Estevam <festevam@...il.com>, mingo@...hat.com,
	peterz@...radead.org, linux-kernel@...r.kernel.org,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH v2] sched: Fix print format for u64


* Paul Turner <pjt@...gle.com> wrote:

> On Thu, Jan 24, 2013 at 11:19 PM, Ingo Molnar <mingo@...nel.org> wrote:
> >
> > * Fabio Estevam <festevam@...il.com> wrote:
> >
> >> On Thu, Jan 24, 2013 at 12:19 PM, Ingo Molnar <mingo@...nel.org> wrote:
> >>
> >> > I suppose - is this patch warning-free both on 64-bit and 32-bit
> >> > systems?
> >>
> >> Yes, just confirmed that this patch is warning-free on both 64-bit and
> >> 32-bit machines.
> >
> > Apparently it's not all good, see the warning attached below.
> 
> Yeah this patch is broken; this is not properly fixable as is without
> #ifdefs (or fixing the insanity that is atomic64_read).
> 
> Specifically:
> 
> On some architectures (e.g. x86_64) atomic64_read is typed long
> On some others (e.g. x86-32) it's typed long long
> On yet others (e.g. arm) it's typed u64

Hm, cannot we type atomic64_read() to u64 on x86-64 as well, and 
fix other architectures? How widespread is this problem, have 
you checked that perhaps?

I'm all for clean, consistent types instead of #ifdef or 
temporary variable uglies.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/