linux-kernel - Re: [PATCH 4/4] async: replace list of active domains with global list of pending items

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130125010112.GF2373@mtj.dyndns.org>
Date:	Thu, 24 Jan 2013 17:01:12 -0800
From:	Tejun Heo <tj@...nel.org>
To:	James Hogan <james@...anarts.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Dan Williams <djbw@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] async: replace list of active domains with global
 list of pending items

Hello,

On Fri, Jan 25, 2013 at 12:13:45AM +0000, James Hogan wrote:
> Should it have this?
> +	else
> +		INIT_LIST_HEAD(&entry->global_list)

I think it would be better to have INIT_LIST_HEAD() during @entry
initialization.  Heh, I forgot that.  I wonder why it didn't crash on
my machine.  Can you please cook up a patch to init both list fields
right after kzalloc()?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/