linux-kernel - Re: [PATCH 2/6] ARM: davinci: da850: add DT node for I2C0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51026365.1020402@ti.com>
Date:	Fri, 25 Jan 2013 16:20:13 +0530
From:	Sekhar Nori <nsekhar@...com>
To:	"Vishwanathrao Badarkhe, Manish" <manishv.b@...com>
CC:	<devicetree-discuss@...ts.ozlabs.org>, <linux-doc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<davinci-linux-open-source@...ux.davincidsp.com>,
	Kevin Hilman <khilman@...prootsystems.com>,
	<linux@....linux.org.uk>, <sameo@...ux.intel.com>,
	<tony@...mide.com>, <broonie@...nsource.wolfsonmicro.com>,
	<rob.herring@...xeda.com>, <grant.likely@...retlab.ca>,
	<rob@...dley.net>, <anilkumar@...com>, <hs@...x.de>
Subject: Re: [PATCH 2/6] ARM: davinci: da850: add DT node for I2C0

On 1/24/2013 5:05 PM, Vishwanathrao Badarkhe, Manish wrote:
> Add I2C0 device tree node information to da850-evm.
> Also, add I2C0 pin muxing information in da850-evm.
> 
> Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@...com>
> ---
> Depends on patch 
> http://comments.gmane.org/gmane.linux.davinci/25993
> 
>  arch/arm/boot/dts/da850-evm.dts |   15 +++++++++++++++
>  arch/arm/boot/dts/da850.dtsi    |   10 ++++++++++
>  2 files changed, 25 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
> index 8cac9d2..3d8290a 100755
> --- a/arch/arm/boot/dts/da850-evm.dts
> +++ b/arch/arm/boot/dts/da850-evm.dts
> @@ -27,5 +27,20 @@
>  		serial2: serial@...d000 {
>  			status = "okay";
>  		};
> +		i2c0@...2000 {

This should be
		i2c0: i2c@...2000

to follow the convention elsewhere in file.

> +			status = "okay";
> +		};
> +	};
> +};
> +&pmx_core {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <
> +		&i2c0_pins
> +	>;
> +
> +	i2c0_pins: pinmux_i2c0_pins{
> +		pinctrl-single,bits = <
> +			0x10 0x00002200 0x0000ff00	/* I2C0_SDA,I2C0_SCL */
> +		>;

This should go into the dtsi file. See the discussion on NAND DT support
submitted by Anil Kumar.

Thanks,
Sekhar

PS: You are using an old address for Kevin Hilman. The MAINTAINERS file
has been updated for a long time now. Liam's address is also wrong but I
don't have his updated e-mail.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/