[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5101E211.20606@huawei.com>
Date: Fri, 25 Jan 2013 09:38:25 +0800
From: Li Zefan <lizefan@...wei.com>
To: Ingo Molnar <mingo@...nel.org>
CC: Tejun Heo <tj@...nel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Peter Zijlstra <peterz@...radead.org>,
LKML <linux-kernel@...r.kernel.org>,
Cgroups <cgroups@...r.kernel.org>
Subject: Re: [PATCH v2 2/6] sched: split out css_online/css_offline from tg
creation/destruction
On 2013/1/24 18:04, Ingo Molnar wrote:
>
> * Li Zefan <lizefan@...wei.com> wrote:
>
>> extern struct task_group *sched_create_group(struct task_group *parent);
>> +extern void sched_online_group(struct task_group *tg,
>> + struct task_group *parent);
>> extern void sched_destroy_group(struct task_group *tg);
>> +extern void sched_offline_group(struct task_group *tg);
>
> Btw., a rename of these APIs might be in order, along the usual
> patterns:
>
> sched_task_group_create()
> sched_task_group_online()
> sched_task_group_offline()
> sched_task_group_destroy()
>
> etc.
>
> that way the naming is more hierarchical and there's no clash
> with the sched_group concept which is about something else.
>
> (In a separate patch.)
>
Agreed. I'll send a cleanup patch to you when those patches hit mainline.
(That will be 3.9-rc1 or later)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists