linux-kernel - Re: [PATCH v4 1/4] drivers: usb: phy: add a new driver for usb part of control module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130125122943.GB16795@e106331-lin.cambridge.arm.com>
Date:	Fri, 25 Jan 2013 12:29:43 +0000
From:	Mark Rutland <mark.rutland@....com>
To:	Felipe Balbi <balbi@...com>
Cc:	Kishon Vijay Abraham I <kishon@...com>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"rob@...dley.net" <rob@...dley.net>,
	"tony@...mide.com" <tony@...mide.com>,
	"b-cousson@...com" <b-cousson@...com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>
Subject: Re: [PATCH v4 1/4] drivers: usb: phy: add a new driver for usb
 part of control module

[...]

> > > +OMAP CONTROL USB
> > > +
> > > +Required properties:
> > > + - compatible: Should be "ti,omap-control-usb"
> > > + - reg : Address and length of the register set for the device. It contains
> > > +   the address of "control_dev_conf" and "otghs_control" or "phy_power_usb"
> > 
> > Could you not use '-' over '_' here?
> 
> that's part of omap hwmod.

Aha, that makes sense (unlike my original comment, now I reread it). Sorry for
the noise.

> > > +   depending upon omap4 or omap5.
> > > + - reg-names: The names of the register addresses corresponding to the registers
> > > +   filled in "reg".
> > > + - ti,type: This is used to differentiate whether the control module has
> > > +   usb mailbox or usb3 phy power. omap4 has usb mailbox in control module to
> > > +   notify events to the musb core and omap5 has usb3 phy power register to
> > > +   power on usb3 phy. Should be "1" if it has mailbox and "2" if it has usb3
> > > +   phy power.
> > 
> > Why not make this a string property, perhaps values "mailbox" or "register"?
> 
> NAK.

Can I ask what your objection to using a string property is?

As far as I can see, "ti,type" is only used by this driver, so there's no
common convention to stick to. Using a string makes the binding easier for
humans to read, and thus harder to mess up in a dts, and it decouples the
binding from kernel-side constants.

Thanks,
Mark.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/