linux-kernel - Re: [patch] backlight: s6e63m0: report ->gamma_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Jan 2013 11:22:06 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Dan Carpenter' <dan.carpenter@...cle.com>
Cc:	'Andrew Morton' <akpm@...ux-foundation.org>,
	'Inki Dae' <inki.dae@...sung.com>,
	'Richard Purdie' <rpurdie@...ys.net>,
	'Florian Tobias Schandinat' <FlorianSchandinat@....de>,
	linux-fbdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org, 'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [patch] backlight: s6e63m0: report ->gamma_table_count correctly

On Thursday, January 24, 2013 10:45 PM, Dan Carpenter wrote

CC'ed Andrew Morton, Inki Dae.

> 
> gamma_table has 3 arrays which each hold MAX_GAMMA_LEVEL pointers to
> int.
> 
> The current code sets ->gamma_table_count to 6 on 64bit arches and to 3
> on 32 bit arches.  It should be 3 on everything.

Actually, I don't know it is right.
However, it is certain that this panel is currently used on 32 bit arches
such as ARM SoCs.

> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> This is from reading the code.  We use ->gamma_table_count in sysfs file
> but other than that I'm not sure what it's for.  I am not very familiar
> with this code.
> 
> diff --git a/drivers/video/backlight/s6e63m0.c b/drivers/video/backlight/s6e63m0.c
> index 2126b96..9c2677f 100644
> --- a/drivers/video/backlight/s6e63m0.c
> +++ b/drivers/video/backlight/s6e63m0.c
> @@ -766,7 +766,7 @@ static int s6e63m0_probe(struct spi_device *spi)
>  	 * know that.
>  	 */
>  	lcd->gamma_table_count =
> -	    sizeof(gamma_table) / (MAX_GAMMA_LEVEL * sizeof(int));
> +	    sizeof(gamma_table) / (MAX_GAMMA_LEVEL * sizeof(int *));
> 
>  	ret = device_create_file(&(spi->dev), &dev_attr_gamma_mode);
>  	if (ret < 0)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/