linux-kernel - Re: [PATCH] extcon: max77693: Fix bug of build error related to INPUT subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5102B9DA.9080306@infradead.org>
Date:	Fri, 25 Jan 2013 08:59:06 -0800
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Chanwoo Choi <cw00.choi@...sung.com>
CC:	sfr@...b.auug.org.au, gregkh@...uxfoundation.org,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	myungjoo.ham@...sung.com, kyungmin.park@...sung.com
Subject: Re: [PATCH] extcon: max77693: Fix bug of build error related to INPUT
 subsystem

On 01/24/13 17:56, Chanwoo Choi wrote:
> This patch fix build error of following log:
> 
> drivers/built-in.o: In function `max77693_muic_remove':
> extcon-max77693.c:(.text+0x664853): undefined reference to `input_unregister_device'
> drivers/built-in.o: In function `max77693_muic_probe':
> extcon-max77693.c:(.text+0x664971): undefined reference to `input_allocate_device'
> extcon-max77693.c:(.text+0x6649c1): undefined reference to `input_set_capability'
> extcon-max77693.c:(.text+0x6649d6): undefined reference to `input_set_capability'
> extcon-max77693.c:(.text+0x6649eb): undefined reference to `input_set_capability'
> extcon-max77693.c:(.text+0x664a00): undefined reference to `input_set_capability'
> extcon-max77693.c:(.text+0x664a15): undefined reference to `input_set_capability'
> extcon-max77693.c:(.text+0x664a20): undefined reference to `input_register_device'
> drivers/built-in.o: In function `max77693_muic_adc_handler':
> extcon-max77693.c:(.text+0x665318): undefined reference to `input_event'
> extcon-max77693.c:(.text+0x66532a): undefined reference to `input_event'
> make[1]: *** [vmlinux] Error 1
> 
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> Signed-off-by: Myungjoo Ham <myungjoo.ham@...sung.com>

Reported-by: Randy Dunlap <rdunlap@...radead.org>
Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  drivers/extcon/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 07122a9..10df3fa 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -29,7 +29,7 @@ config EXTCON_ADC_JACK
>  
>  config EXTCON_MAX77693
>  	tristate "MAX77693 EXTCON Support"
> -	depends on MFD_MAX77693
> +	depends on MFD_MAX77693 && INPUT
>  	select IRQ_DOMAIN
>  	select REGMAP_I2C
>  	help
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/