linux-kernel - Re: [PATCHv2 5/9] debugfs: add get/set for atomic types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Jan 2013 13:35:07 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Seth Jennings <sjenning@...ux.vnet.ibm.com>
Cc:	devel@...verdev.osuosl.org, Rik van Riel <riel@...hat.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Minchan Kim <minchan@...nel.org>, linux-kernel@...r.kernel.org,
	Johannes Weiner <jweiner@...hat.com>, linux-mm@...ck.org,
	Mel Gorman <mgorman@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Robert Jennings <rcj@...ux.vnet.ibm.com>,
	Dan Magenheimer <dan.magenheimer@...cle.com>,
	Larry Woodman <lwoodman@...hat.com>,
	Nitin Gupta <ngupta@...are.org>,
	Jenifer Hopper <jhopper@...ibm.com>
Subject: Re: [PATCHv2 5/9] debugfs: add get/set for atomic types

On Fri, Jan 25, 2013 at 10:45:04AM -0600, Seth Jennings wrote:
> On 01/07/2013 02:41 PM, Seth Jennings wrote:
> > On 01/07/2013 02:32 PM, Greg Kroah-Hartman wrote:
> >> On Mon, Jan 07, 2013 at 02:24:36PM -0600, Seth Jennings wrote:
> >>> debugfs currently lack the ability to create attributes
> >>> that set/get atomic_t values.
> >>
> >> I hate to ask, but why would you ever want to do such a thing?
> > 
> > There are a few atomic_t statistics in zswap that are valuable to have
> > in the debugfs attributes.  Rather than have non-atomic mirrors of all
> > of them, as is done in zcache right now (see
> > drivers/staging/ramster/zcache-main.c:131), I thought this to be a
> > cleaner solution.
> > 
> > Granted, I personally have no use for the setting part; only the
> > getting part.  I only included the setting operations to keep the
> > balance and conform with the rest of the debugfs implementation.
> 
> Greg, I never did get your ack or rejection here.  Are you ok with
> this patch?

Some patches you just hold your breath and hope the sender goes away and
never asks about again, this was one of them :)

Seriously, it's fine, feel free to take it through whatever tree it
depends on.

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/