linux-kernel - Re: [PATCH 23/74] perf kvm: Initialize file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5101F555.30403@linux.vnet.ibm.com>
Date:	Fri, 25 Jan 2013 11:00:37 +0800
From:	Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>
To:	Arnaldo Carvalho de Melo <acme@...radead.org>
CC:	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>, Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 23/74] perf kvm: Initialize file_name var to fix segfault

On 01/25/2013 04:07 AM, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@...hat.com>
> 
> The 3786063 commit:
> 
>     perf kvm: Rename perf_kvm to perf_kvm_stat
> 
> Moved the file_name from inside a local struct var that initialized some
> of its members, thus zero initializing the not explicitely initialized
> variables, one of which was 'file_name', to a standalone local variable,
> but forgot to initialize it explicitely to NULL, so it then got some
> undefined value, causing a segfault in strdup when it wasn't, by luck,
> zero.
> 
> Fix it by explicitely initializing it to NULL.

Thank you for fixing my fault.

Reviewed-by: Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/