linux-kernel - Re: [PATCH 04/14] firewire: don't use idr_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130126100707.5c7a7682@stein>
Date:	Sat, 26 Jan 2013 10:07:07 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Tejun Heo <tj@...nel.org>
Cc:	akpm@...ux-foundation.org, rusty@...tcorp.com.au,
	linux-kernel@...r.kernel.org, linux1394-devel@...ts.sourceforge.net
Subject: Re: [PATCH 04/14] firewire: don't use idr_remove_all()

On Jan 25 Tejun Heo wrote:
> idr_destroy() can destroy idr by itself and idr_remove_all() is being
> deprecated.  Drop its usage.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Stefan Richter <stefanr@...6.in-berlin.de>
> Cc: linux1394-devel@...ts.sourceforge.net
> ---
> This patch depends on an earlier idr patch and given the trivial
> nature of the patch, I think it would be best to route these together
> through -mm.  Please holler if there's any objection.

Acked-by: Stefan Richter <stefanr@...6.in-berlin.de>

> Thanks.
> 
>  drivers/firewire/core-cdev.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/firewire/core-cdev.c b/drivers/firewire/core-cdev.c
> index f8d2287..68c3138 100644
> --- a/drivers/firewire/core-cdev.c
> +++ b/drivers/firewire/core-cdev.c
> @@ -1779,7 +1779,6 @@ static int fw_device_op_release(struct inode *inode, struct file *file)
>  	wait_event(client->tx_flush_wait, !has_outbound_transactions(client));
>  
>  	idr_for_each(&client->resource_idr, shutdown_resource, client);
> -	idr_remove_all(&client->resource_idr);
>  	idr_destroy(&client->resource_idr);
>  
>  	list_for_each_entry_safe(event, next_event, &client->event_list, link)



-- 
Stefan Richter
-=====-===-= ---= ==-=-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/