[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130126143950.GA7079@S2101-09.ap.freescale.net>
Date: Sat, 26 Jan 2013 22:39:53 +0800
From: Shawn Guo <shawn.guo@...aro.org>
To: Mark Langsdorf <mark.langsdorf@...xeda.com>
CC: <linux-kernel@...r.kernel.org>, <cpufreq@...r.kernel.org>,
<linux-pm@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 4/4] cpufreq, highbank: add support for highbank cpufreq
Mark,
On Fri, Jan 25, 2013 at 01:46:45PM -0600, Mark Langsdorf wrote:
> +static int hb_cpufreq_driver_init(void)
> +{
> + struct device *cpu_dev;
> + struct clk *cpu_clk;
> + struct device_node *np;
> + int ret;
> +
> + for_each_child_of_node(of_find_node_by_path("/cpus"), np)
> + if (of_get_property(np, "operating-points", NULL))
> + break;
> +
> + if (!np) {
> + pr_err("failed to find highbank cpufreq node\n");
> + return -ENOENT;
> + }
> +
...
> +out_put_node:
> + of_node_put(np);
> + return ret;
> +}
> +module_init(hb_cpufreq_driver_init);
As we are moving to multiplatform build, this init function will run
on all other platforms built together with highbank. We should
probably eliminate that effect. cpufreq-cpu0 driver is facing the
same problem, and I just sent a patch "cpufreq: instantiate cpufreq-cpu0
as a platform_driver" to address that.
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists