lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 26 Jan 2013 17:24:42 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	anish kumar <anish198519851985@...il.com>
Cc:	rostedt@...dmis.org, linux-kernel@...r.kernel.org,
	peterz@...radead.org, akpm@...ux-foundation.org,
	paul.gortmaker@...driver.com, tglx@...utronix.de, mingo@...nel.org
Subject: Re: [PATCH] IRQ CORE: irq_work_queue function return value not used.

2012/11/3 anish kumar <anish198519851985@...il.com>:
> From: anish kumar <anish198519851985@...il.com>
>
> As no one is using the return value of irq_work_queue function
> it is better to just make it void.
>
> Acked-by: Steven Rostedt <rostedt@...dmis.org>
> Signed-off-by: anish kumar <anish198519851985@...il.com>
> ---
>  kernel/irq_work.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/irq_work.c b/kernel/irq_work.c
> index 1588e3b..4829a31 100644
> --- a/kernel/irq_work.c
> +++ b/kernel/irq_work.c
> @@ -79,17 +79,16 @@ static void __irq_work_queue(struct irq_work *work)
>   *
>   * Can be re-enqueued while the callback is still in progress.
>   */
> -bool irq_work_queue(struct irq_work *work)
> +void irq_work_queue(struct irq_work *work)

Please also update the headers in include/linux/irq_work.h accordingly.

Thanks.

>  {
>         if (!irq_work_claim(work)) {
>                 /*
>                  * Already enqueued, can't do!
>                  */
> -               return false;
> +               return;
>         }
>
>         __irq_work_queue(work);
> -       return true;
>  }
>  EXPORT_SYMBOL_GPL(irq_work_queue);
>
> --
> 1.7.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists