linux-kernel - Re: [PATCH] mips: Move __virt_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130126211930.GG23053@blackmetal.musicnaut.iki.fi>
Date:	Sat, 26 Jan 2013 23:19:30 +0200
From:	Aaro Koskinen <aaro.koskinen@....fi>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	linux-mips <linux-mips@...ux-mips.org>,
	Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: [PATCH] mips: Move __virt_addr_valid() to a place for MIPS 64

Hi,

On Sat, Jan 26, 2013 at 04:01:44PM -0500, Steven Rostedt wrote:
> On Sat, 2013-01-26 at 22:15 +0200, Aaro Koskinen wrote:
> > On Fri, Jan 25, 2013 at 01:13:15PM -0500, Steven Rostedt wrote:
> > > Commit d3ce88431892 "MIPS: Fix modpost error in modules attepting to use
> > > virt_addr_valid()" moved __virt_addr_valid() from a macro in a header
> > > file to a function in ioremap.c. But ioremap.c is only compiled for MIPS
> > > 32, and not for MIPS 64.
> > > 
> > > When compiling for my yeeloong2, which supposedly supports hibernation,
> > > which compiles kernel/power/snapshot.c which calls virt_addr_valid(), I
> > > got this error:
> > 
> > This has been reported also here:
> > 
> > 	http://marc.info/?l=linux-mips&m=135788867604856&w=2
> > 
> > and here:
> > 
> > 	http://marc.info/?l=linux-mips&m=135876719403187&w=2
> > 
> 
> Hmm, interesting. Although, I prefer my change as it doesn't require
> compiling all of ioremap.c where it's not needed.

Yes, I think your solution is fine.

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/