linux-kernel - Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130127001347.584711b2@xenia>
Date:	Sun, 27 Jan 2013 00:13:47 +0100
From:	Michael Leun <lkml20130126@...ton.leun.net>
To:	Freddy Xin <freddy@...x.com.tw>
Cc:	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, louis@...x.com.tw,
	davem@...emloft.net, Support@...x.com.tw
Subject: Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0
 to gigabit ethernet adapter driver

On Wed, 23 Jan 2013 10:32:17 +0800
Freddy Xin <freddy@...x.com.tw> wrote:

> This is a resubmission.
> Fixed coding style errors.
[...]
> This patch adds a driver for ASIX's AX88179 family of USB 3.0/2.0
> to gigabit ethernet adapters. It's based on the AX88xxx driver but

I hope, there is some error/mistake on my side, otherwise I fear I
would have to say I find this driver to be total crap.

I tried it with an Digitus DN-3023 identifying itself as idVendor=0b95,
idProduct=1790 (some internet source claims it to be actually based on
asix reference design).

If I plug the device in the interface comes up with an mtu of 1488 -
this would be an very bad joke for any ethernet compliant device, even
more for an gigabit device where you clearly want to see at least a bit
of jumbo frames.

If I set the mtu to 1500 (the driver does not even complain when I set
the mtu to e.g. 2^31-1) and start to send bigger packets in some point
of time the device stops to work - means, after that you cannot even
send smaller packets, after some time you might get an kernel warning
"NETDEV WATCHDOG: eth3 (ax88179_178a): transmit queue 0 timed out" and
you have to unplug / replug the device to get it working again.

Note: With the W$ driver and exactly the same hardware you get at least
jumbo frames up to some 4000+X bytes - not great, but better than
nothing.

I would vote to not accept that driver for mainline as long as this
issues are not fixed. 

The vendor should not be able to claim "hooray, hooray, great device,
we even have an driver in linux main line" when it is actually such an
useless crap.

Of course I'm offering to help with any information or testing, but
unfortunately I do not have the knowhow to fix anything myself. 

-- 
MfG,

Michael Leun

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/