linux-kernel - Re: [PATCH] mmc: fix to refer NULL pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1301270906270.5137@axis700.grange>
Date:	Sun, 27 Jan 2013 09:10:27 +0100 (CET)
From:	Guennadi Liakhovetski <g.liakhovetski@....de>
To:	Joonyoung Shim <jy0922.shim@...sung.com>
cc:	cjb@...top.org, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: fix to refer NULL pointer

On Sat, 26 Jan 2013, Joonyoung Shim wrote:

> Check whether host->sdio_irq_thread is NULL before wake_up_process() is
> called about host->sdio_irq_thread.

Actually, mmc_signal_sdio_irq() shouldn't be called if SDIO IRQ isn't 
used...

Thanks
Guennadi

> 
> Signed-off-by: Joonyoung Shim <jy0922.shim@...sung.com>
> ---
> Currently the kernel panic to refer NULL pointer about
> host->sdio_irq_thread are occuring at the trats board using Samsung
> SDHCI driver.
> 
>  include/linux/mmc/host.h |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
> index 61a10c1..2950fea 100644
> --- a/include/linux/mmc/host.h
> +++ b/include/linux/mmc/host.h
> @@ -372,7 +372,8 @@ static inline void mmc_signal_sdio_irq(struct mmc_host *host)
>  {
>  	host->ops->enable_sdio_irq(host, 0);
>  	host->sdio_irq_pending = true;
> -	wake_up_process(host->sdio_irq_thread);
> +	if (host->sdio_irq_thread)
> +		wake_up_process(host->sdio_irq_thread);
>  }
>  
>  #ifdef CONFIG_REGULATOR
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/