Date:	Sun, 27 Jan 2013 11:19:31 +0000
From:	Chris Clayton <chris2553@...glemail.com>
To:	Yijing Wang <wangyijing0307@...il.com>
CC:	Martin Mokrejs <mmokrejs@...d.natur.cuni.cz>,
	linux-media@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	linux-pci@...r.kernel.org
Subject: Re: 3.8.0-rc4+ - Oops on removing WinTV-HVR-1400 expresscard TV Tuner

Hi Yijing

On 01/27/13 02:45, Yijing Wang wrote:
> 于 2013-01-27 4:54, Chris Clayton 写道:
>> Hi Martin,
>>
>> On 01/24/13 19:21, Martin Mokrejs wrote:
>>> Hi Chris,
>>>     try to include in kernel only acpiphp and omit pciehp. Don't use modules but include
>>> them statically. And try, in addition, check whether "pcie_aspm=off" in grub.conf helped.
>>>
>>
>> Thanks for the tip. I had the pciehp driver installed, but it was a module and not loaded. I didn't have acpiphp enabled at all. Building them both in statically, appears to have papered over the cracks of the oops :-)
>
> Not loaded pciehp driver? Remove the device from this slot without poweroff ?
>

That's correct. When I first encountered the oops, I did not have the 
pciehp driver loaded and removing the device from the slot whilst the 
laptop was powered on resulted in the oops.
>>
>>>     The best would if you subscribe to linux-pci, and read my recent threads
>>> about similar issues I had with express cards with Dell Vostro 3550. Further, there is
>>> a lot of changes to PCI hotplug done by Yingahi Liu and Rafael Wysockij, just browse the
>>> archives of linux-pci and see the pacthes and the discussion.
>>
>> Those discussions are way above my level of knowledge. I guess all this work will be merged into mainline in due course, so I'll watch for them in 3.9 or later. Unless, of course, there is a tree I could clone and help test the changes with my laptop and expresscard.
>>
>> Hotplug isn't working at all on my Fujitsu laptop, so I can only get the card recognised by rebooting with the card inserted (or by writing 1 to/sys/bus/pci/rescan). There seem to be a few reports on this in the kernel bugzilla, so I'll look through them and see what's being done.
>
> Hi Chris,
>     What about use #modprobe pciehp pciehp_debug=1 pciehp_poll_mode=1 pciehp_poll_time=1 ?
>
> Can you resend the dmesg log and "lspci -vvv" info after hotplug device from your Fujitsu laptop with above module parameters?
>

I wasn't sure whether or not the pciehp driver should be loaded on its 
own or with the acpiphp driver also loaded. So I built them both as 
modules and planned to try both, pciehp only and acpiphp only. However, 
I've found that acpiphp will not load (regardless of whether or not 
pciehp is already loaded). What I get is:

[chris:~]$ sudo modprobe acpiphp debug=1
modprobe: ERROR: could not insert 'acpiphp': No such device

and at the end of the dmesg output I see:

[   68.199789] acpiphp: ACPI Hot Plug PCI Controller Driver version: 0.5
[   68.199970] acpiphp_glue: Total 0 slots

The pciehp driver loads OK. I've attached pciehp-only which shows the 
dmesg and lscpi output that you asked for.

As I said before, the only way that I can get the card detected with 
rebooting the laptop is to write 1 to /sys/bus/pci/rescan. In the hope 
that it might help (e.g. it shows details of the expresscard I'm using), 
I've also attached the output from dmesg and lspci after a rescan.

Please let me know if I can provide any additional diagnostics.

Thanks,
Chris
> Thanks!
> Yijing.
>
>> Thanks again.
>>
>> Chris
>>
>>> Martin
>>>
>>> Chris Clayton wrote:
>>>> Hi,
>>>>
>>>> I've today taken delivery of a WinTV-HVR-1400 expresscard TV Tuner and got an Oops when I removed from the expresscard slot in my laptop. I will quite understand if the response to this report is "don't do that!", but in that case, how should one remove one of these cards?
>>>>
>>>> I have attached three files:
>>>>
>>>> 1. the dmesg output from when I rebooted the machine after the oops. I have turned debugging on in the dib700p and cx23885 modules via modules options in /etc/modprobe.d/hvr1400.conf;
>>>>
>>>> 2. the .config file for the kernel that oopsed.
>>>>
>>>> 3. the text of the oops message. I've typed this up from a photograph of the screen because the laptop was locked up and there was nothing in the log files. Apologies for any typos, but I have tried to be careful.
>>>>
>>>> Assuming the answer isn't don't do that, let me know if I can provide any additional diagnostics, test any patches, etc. Please, however, cc me as I'm not subscribed.
>>>>
>>>> Chris
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>

View attachment "pciehp-only" of type "text/plain" (62128 bytes)

View attachment "pci-bus-rescan" of type "text/plain" (75714 bytes)

Powered by blists - more mailing lists