linux-kernel - Re: [PATCH v2 3/4] regulator-core: free requested GPIOs and manage the enable list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130127061034.GC8952@opensource.wolfsonmicro.com>
Date:	Sun, 27 Jan 2013 14:10:37 +0800
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	"Kim, Milo" <Milo.Kim@...com>
Cc:	Axel Lin <axel.lin@...ics.com>, "Girdwood, Liam" <lrg@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/4] regulator-core: free requested GPIOs and manage
 the enable list

On Tue, Jan 15, 2013 at 04:35:50AM +0000, Kim, Milo wrote:
>  The regulator_ena_gpio_request() allocates the enable GPIO and add the list.
>  Related resources should be released if they are not used any more.
>  To free requested GPIO and remove it from the enable GPIO list,
>  new function, 'regulator_ena_gpio_free()' is added.

Ah, sorry - I hadn't realised this patch had the cleanup code.  This
needs a bit of an update - as I said for one of the earlier patches we
need to reference count to make sure we only free the GPIO when it has
no users.  With this patch we will free the GPIO when the first
regulator to use it is freed which might mean other regulators are still
using it.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)