linux-kernel - Re: [PATCH 3/3] ALSA: intel8x0: Check return value before assigning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h622hbsnh.wl%tiwai@suse.de>
Date:	Mon, 28 Jan 2013 09:47:46 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Emil Goode <emilgoode@...il.com>
Cc:	mtosatti@...hat.com, gleb@...hat.com, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com, avi@...hat.com, mst@...hat.com,
	perex@...ex.cz, crimsun@...ntu.com, wfp5p@...ginia.edu,
	peter.senna@...il.com, x86@...nel.org, kvm@...r.kernel.org,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/3] ALSA: intel8x0: Check return value before assigning

At Sun, 27 Jan 2013 17:40:02 +0100,
Emil Goode wrote:
> 
> The first patch in this series changes the return type of function
> kvm_para_available to bool. In the function snd_intel8x0_inside_vm
> we now need to check it's return value before assigning a value to
> the result variable.
> 
> Signed-off-by: Emil Goode <emilgoode@...il.com>
> ---
>  sound/pci/intel8x0.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c
> index 3b9be75..fa9337e 100644
> --- a/sound/pci/intel8x0.c
> +++ b/sound/pci/intel8x0.c
> @@ -2982,7 +2982,7 @@ static int snd_intel8x0_inside_vm(struct pci_dev *pci)
>  	}
>  
>  	/* detect KVM and Parallels virtual environments */
> -	result = kvm_para_available();
> +	result = kvm_para_available() ? 1 : 0;

This is superfluous.  The conversion from bool to int works implicitly
like that.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/