| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <2266358.qvDXKLvJ67@storm> Date: Mon, 28 Jan 2013 09:56:49 +0100 From: Thomas Jarosch <thomas.jarosch@...ra2net.com> To: acme@...stprotocols.net Cc: linux-kernel@...r.kernel.org Subject: [perf PATCH] Fix NULL pointer dereference on error pclose(NULL) is undefined behavior and crashes. Signed-off-by: Thomas Jarosch <thomas.jarosch@...ra2net.com> --- tools/perf/util/sort.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index a83ded2..8333661 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c @@ -279,10 +279,12 @@ static int hist_entry__srcline_snprintf(struct hist_entry *self, char *bf, *nl = '\0'; path = self->srcline; out_path: - pclose(fp); + if (fp) + pclose(fp); return repsep_snprintf(bf, size, "%s", path); out_ip: - pclose(fp); + if (fp) + pclose(fp); return repsep_snprintf(bf, size, "%-#*llx", BITS_PER_LONG / 4, self->ip); } -- 1.7.11.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists