linux-kernel - Re: [PATCH 1/8] perf tools: Add '.' as part of the event 'name' token

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130129080305.GB594@gmail.com>
Date:	Tue, 29 Jan 2013 09:03:05 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	Jiri Olsa <jolsa@...hat.com>, LKML <linux-kernel@...r.kernel.org>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Namhyung Kim <namhyung@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 1/8] perf tools: Add '.' as part of the event 'name' token


* Stephane Eranian <eranian@...gle.com> wrote:

> On Mon, Jan 28, 2013 at 9:52 PM, Stephane Eranian <eranian@...gle.com> wrote:
> > Jiri,
> >
> > I don't see part 0/8 of this series. Did you send it to me too?
> >
> > I have some comments about it. I don't see why create something from scratch
> > when I have been developing a library (libpfm4) that takes care of that and that
> > is already used by many tool developers. That library can be linked with perf
> > and provide full symbolic events + all the modifiers. The library is portable
> > and supports all existing archs. It can also be used by self-monitoring apps.
> >
> >
> > You're introducing yet another event table to maintain. And believe me this is
> > a lot of work to maintain this.
> >
> > I don't understand why not use this existing library.
> >
>
> I meant to add that I think it would be more productive if we 
> (you and I) were to work on the library to extend it with 
> external text-based event tables that could be used by perf 
> either directly or thru the libpfm4 interface.

perf is intentionally external file free and does not 
(fundamentally) depend on external libraries either,
other than core system libraries.

There are several advantages to that:

 - there is no version skew and no design/maintenance friction

 - 'upgrading' perf between similar boxes is as simple as
   copying the perf binary

 - it's self-sufficient

 - there's no real advantage of external text files versus
   internal text files (i.e. text tables within the source 
   code), while there are several disadvantages

So as long as Jiri is happy to maintain these tables I think 
it's a superior solution (even if the tables start out 
incomplete), from the perf project's perspective.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/