linux-kernel - Re: [PATCH 1/2] drm/cirrus: Correct register values for 16bpp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hvcags8c0.wl%tiwai@suse.de>
Date:	Tue, 29 Jan 2013 09:26:55 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	David Airlie <airlied@...ux.ie>
Cc:	Stefan Dirsch <sndirsch@...e.de>,
	Bernhard Wiedemann <bwiedemann@...e.com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] drm/cirrus: Correct register values for 16bpp

Hi Dave,

any chance to take a look at this problem?


thanks,

Takashi

At Fri, 25 Jan 2013 17:21:54 +0100,
Takashi Iwai wrote:
> 
> When the mode is set with 16bpp on QEMU, the output gets totally
> broken.  The culprit is the bogus register values set for 16bpp,
> which was likely copied from from a wrong place.
> 
> Bugzilla: https://bugzilla.novell.com/show_bug.cgi?id=799216
> 
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Takashi Iwai <tiwai@...e.de>
> ---
>  drivers/gpu/drm/cirrus/cirrus_mode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c b/drivers/gpu/drm/cirrus/cirrus_mode.c
> index 60685b2..379a47e 100644
> --- a/drivers/gpu/drm/cirrus/cirrus_mode.c
> +++ b/drivers/gpu/drm/cirrus/cirrus_mode.c
> @@ -273,8 +273,8 @@ static int cirrus_crtc_mode_set(struct drm_crtc *crtc,
>  		sr07 |= 0x11;
>  		break;
>  	case 16:
> -		sr07 |= 0xc1;
> -		hdr = 0xc0;
> +		sr07 |= 0x17;
> +		hdr = 0xc1;
>  		break;
>  	case 24:
>  		sr07 |= 0x15;
> -- 
> 1.8.1.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/