linux-kernel - Re: aim7 performance regression by commit 5a50508 report from LKP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Jan 2013 09:44:00 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Yuanhan Liu <yuanhan.liu@...ux.intel.com>
Cc:	Huang Ying <ying.huang@...el.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	David Howells <dhowells@...hat.com>,
	linux-kernel@...r.kernel.org, lkp@...ux.intel.com
Subject: Re: aim7 performance regression by commit 5a50508 report from LKP


* Yuanhan Liu <yuanhan.liu@...ux.intel.com> wrote:

> [...]

Very nice measurements and analysis, thanks!

> As stated above, anybody can have a chance to own the lock in 
> mutex once somebody release the lock. Well, there is only one 
> to own the lock in rwsem write lock, and the one is known 
> already: the one in the head of wait list. That would result 
> to more contention in rwsem write lock case, especially if the 
> one _will_ own the lock is not running now.

I think we should allow lock-steal between rwsem writers - that 
will not hurt fairness as most rwsem fairness concerns relate to 
reader vs. writer fairness.

Am I correct to assume that all relevant users in this workload 
are down_write() users?

You can see the type of lock use in:

   perf record -g
   perf report

I bet that allowing rwsem writer lock-steal would improve other 
workloads as well.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/