linux-kernel - Re: [PATCH] x86/apic: check FADT settings after enable x2apic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130129084914.GB5350@gmail.com>
Date:	Tue, 29 Jan 2013 09:49:14 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	"Wang, Song-Bo (Stoney)" <song-bo.wang@...com>
Cc:	"mingo.kernel.org@...il.com" <mingo.kernel.org@...il.com>,
	Yinghai Lu <yinghai@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Zhang, Lin-Bao (Linux Kernel R&D)" <linbao.zhang@...com>,
	"Pearson, Greg" <greg.pearson@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"suresh.b.siddha@...el.com" <suresh.b.siddha@...el.com>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] x86/apic: check FADT settings after enable x2apic


* Wang, Song-Bo (Stoney) <song-bo.wang@...com> wrote:

> [...] Due to this mode mismatch, with specific HW 
> configurations, there will be intermittent lost interrupts, 
> which could result in a hang or data loss.

That's the key piece of information that was missing - which 
should be put into the changelog into a very prominent place.

> Logically, there is a mismatch because the kernel missed 
> detection on HW configurations, and we should fix it, right? 
> Do we need more detailed information?

No, the above sentence is more than enough and the fix looks 
nice. Note that this sentence is more useful to users than the 
rest of the changelog combined!

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/