linux-kernel - Re: [PATCH 2/2] perf: Make -lnuma optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130129104958.GC14302@pd.tnic>
Date:	Tue, 29 Jan 2013 11:49:58 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Ingo Molnar <mingo@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, Borislav Petkov <bp@...e.de>
Subject: Re: [PATCH 2/2] perf: Make -lnuma optional

On Tue, Jan 29, 2013 at 11:48:12AM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
> 
> a0c17eadf3bf9 ("perf: Add 'perf bench numa mem' NUMA performance
> measurement suite") added -lnuma to the EXTLIBS but we use those when
> checking for other libraries like libelf, libunwind, etc and the checks
> failed even when the dev libraries are installed on the system:
> 
>     CHK libelf
> /usr/bin/ld: cannot find -lnuma
> collect2: error: ld returned 1 exit status
>     CHK glibc
> Makefile:552: No libelf found, disables 'probe' tool, please install elfutils-libelf-devel/libelf-dev
>     CHK libunwind
> /usr/bin/ld: cannot find -lnuma
> collect2: error: ld returned 1 exit status
> Makefile:586: No libunwind found, disabling post unwind support. Please install libunwind-dev[el] >= 0.99
> ...
> 
> So, add glue to detect the presence of -lnuma and build perf bench numa
> only then.

While at it, I noticed another annoyance: if FLEX and BISON are needed
unconditionally for the build, this needs to be checked at the beginning
of the makefile and make shouldn't fail in-between. Oh well, I'll let
someone beat me to it with a fix since I'm lazy :).

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/