linux-kernel - Re: [PATCH 3/5] kprobes: constify check_kprobe_address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5107B670.1000800@hitachi.com>
Date:	Tue, 29 Jan 2013 20:45:52 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	Sasha Levin <sasha.levin@...cle.com>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	rostedt@...dmis.org, fweisbec@...il.com, rusty@...tcorp.com.au,
	ananth@...ibm.com, anil.s.keshavamurthy@...el.com,
	jbaron@...hat.com, x86@...nel.org, linux-kernel@...r.kernel.org,
	"yrl.pp-manager.tt@...achi.com" <yrl.pp-manager.tt@...achi.com>
Subject: Re: [PATCH 3/5] kprobes: constify check_kprobe_address_safe and friends

(2013/01/25 13:09), Sasha Levin wrote:
> As to arch_check_optimized_kprobe() and check_kprobe_address_safe(), this
> is simply way too confusing. It doesn't make sense that a function named
> check_[...]() would modify any of it's parameters.
> 
> For example, that entire block within KPROBES_CAN_USE_FTRACE should be split
> out and go into update_kprobe_for_ftrace() or something similar.
> 
> If that makes sense, I can send a patch to split out all the parts that
> modify anything in those two functions out of them.

I see, that makes sense :-)

Thank you,

-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@...achi.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/