lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Jan 2013 15:01:27 +0200 From: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com> To: Hillf Danton <dhillf@...il.com>, "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com> Cc: Andrea Arcangeli <aarcange@...hat.com>, Andrew Morton <akpm@...ux-foundation.org>, Al Viro <viro@...iv.linux.org.uk>, Wu Fengguang <fengguang.wu@...el.com>, Jan Kara <jack@...e.cz>, Mel Gorman <mgorman@...e.de>, linux-mm@...ck.org, Andi Kleen <ak@...ux.intel.com>, Matthew Wilcox <matthew.r.wilcox@...el.com>, "Kirill A. Shutemov" <kirill@...temov.name>, linux-fsdevel <linux-fsdevel@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH, RFC 06/16] thp, mm: rewrite add_to_page_cache_locked() to support huge pages Hillf Danton wrote: > On Mon, Jan 28, 2013 at 5:24 PM, Kirill A. Shutemov > <kirill.shutemov@...ux.intel.com> wrote: > > @@ -443,6 +443,7 @@ int add_to_page_cache_locked(struct page *page, struct address_space *mapping, > > pgoff_t offset, gfp_t gfp_mask) > > { > > int error; > > + int nr = 1; > > > > VM_BUG_ON(!PageLocked(page)); > > VM_BUG_ON(PageSwapBacked(page)); > > @@ -450,31 +451,61 @@ int add_to_page_cache_locked(struct page *page, struct address_space *mapping, > > error = mem_cgroup_cache_charge(page, current->mm, > > gfp_mask & GFP_RECLAIM_MASK); > > if (error) > > - goto out; > > + return error; > > Due to PageCompound check, thp could not be charged effectively. > Any change added for charging it? I've missed this. Will fix. -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists