linux-kernel - Re: Re:[PATCH]sched/rt: Do not try to push tasks if pinned task switches to RT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1359465545.17639.19.camel@gandalf.local.home>
Date:	Tue, 29 Jan 2013 08:19:05 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Kirill Tkhai <tkhai@...dex.ru>
Cc:	Libo Chen <chenlibo.3@...il.com>, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-rt-users <linux-rt-users@...r.kernel.org>,
	lizefan@...wei.com, jovi.zhangwei@...wei.com
Subject: Re: Re:[PATCH]sched/rt: Do not try to push tasks if pinned task
 switches to RT

On Tue, 2013-01-29 at 13:13 +0400, Kirill Tkhai wrote:

> > 
> > The task of p->nr_cpus_allowed =1 would`t be added to pushable_tasks list （see the enqueue_task_rt()）and this push_rt_task() need to push other tasks when rt.overloaded.
> 
> If rq has already had 2 or more pushable tasks and we try to add a pinned task then call of push_rt_task will just waste a time.
> 

Correct, I just have some minor comments about the patch.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/