linux-kernel - [PATCH] x86, efi: remove attribute check from setup_efi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5107FE48.7080402@canonical.com>
Date:	Tue, 29 Jan 2013 17:52:24 +0100
From:	Maarten Lankhorst <maarten.lankhorst@...onical.com>
To:	Matthew Garrett <mjg@...hat.com>,
	Matt Fleming <matt.fleming@...el.com>
CC:	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Sasha Levin <sasha.levin@...cle.com>,
	LKML <linux-kernel@...r.kernel.org>, linux-efi@...r.kernel.org,
	x86@...nel.org
Subject: [PATCH] x86, efi: remove attribute check from setup_efi_pci

It looks like the original commit that copied the rom contents from efi always copied
the rom, and the fixup in setup_efi_pci from commit 886d751a2ea99a160
("x86, efi: correct precedence of operators in setup_efi_pci") broke that.

This resulted in macbook pro's no longer finding the rom images, and thus not being able to use the radeon card any more.

The solution is to just remove the check for now, and always copy the rom if available.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@...onical.com>
---
diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
index 18e329c..ce06324 100644
--- a/arch/x86/boot/compressed/eboot.c
+++ b/arch/x86/boot/compressed/eboot.c
@@ -302,9 +302,6 @@ static efi_status_t setup_efi_pci(struct boot_params *params)
 		if (status != EFI_SUCCESS)
 			continue;
 
-		if (!(attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM))
-			continue;
-
 		if (!pci->romimage || !pci->romsize)
 			continue;
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/