linux-kernel - Re: [PATCH 1/2] sched: move scheduler sysctl bits into dedicated header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130129115542.5a7766fd@redhat.com>
Date:	Tue, 29 Jan 2013 11:55:42 -0600
From:	Clark Williams <williams@...hat.com>
To:	Li Zefan <lizefan@...wei.com>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>,
	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] sched: move scheduler sysctl bits into dedicated
 header file

On Tue, 29 Jan 2013 09:12:45 +0800
Li Zefan <lizefan@...wei.com> wrote:

> > -extern void sched_autogroup_create_attach(struct task_struct *p);
> > -extern void sched_autogroup_detach(struct task_struct *p);
> > -extern void sched_autogroup_fork(struct signal_struct *sig);
> > -extern void sched_autogroup_exit(struct signal_struct *sig);
> > -#ifdef CONFIG_PROC_FS
> > -extern void proc_sched_autogroup_show_task(struct task_struct *p, struct seq_file *m);
> > -extern int proc_sched_autogroup_set_nice(struct task_struct *p, int nice);
> > -#endif
> > -#else
> > -static inline void sched_autogroup_create_attach(struct task_struct *p) { }
> > -static inline void sched_autogroup_detach(struct task_struct *p) { }
> > -static inline void sched_autogroup_fork(struct signal_struct *sig) { }
> > -static inline void sched_autogroup_exit(struct signal_struct *sig) { }
> > -#endif
> 
> but those function declarations have nothing to do with sysctl..
> 
> > -
> > -#ifdef CONFIG_CFS_BANDWIDTH
> > -extern unsigned int sysctl_sched_cfs_bandwidth_slice;
> > -#endif
> > -
> 


True, but they're all under the SCHED_AUTOGROUP config variable along
with:
	extern unsigned int sysctl_sched_autogroup_enabled;

So I thought I'd keep them all grouped together. 

I can move the prototypes back into sched.h but the whole reason for
doing this is to reduce the size of sched. 

Guess I'll let Ingo make the call here. 

Clark

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)