linux-kernel - Re: [PATCH] x86/apic: check FADT settings after enable x2apic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQXe2QHacwyJx+5MQWmoGYW1Swnr5M-MSircgfA4_9e19Q@mail.gmail.com>
Date:	Tue, 29 Jan 2013 13:52:31 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	"Wang, Song-Bo (Stoney)" <song-bo.wang@...com>,
	"mingo.kernel.org@...il.com" <mingo.kernel.org@...il.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Zhang, Lin-Bao (Linux Kernel R&D)" <linbao.zhang@...com>,
	"Pearson, Greg" <greg.pearson@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"suresh.b.siddha@...el.com" <suresh.b.siddha@...el.com>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] x86/apic: check FADT settings after enable x2apic

On Tue, Jan 29, 2013 at 12:49 AM, Ingo Molnar <mingo@...nel.org> wrote:
>
> * Wang, Song-Bo (Stoney) <song-bo.wang@...com> wrote:
>
>> [...] Due to this mode mismatch, with specific HW
>> configurations, there will be intermittent lost interrupts,
>> which could result in a hang or data loss.
>
> That's the key piece of information that was missing - which
> should be put into the changelog into a very prominent place.
>
>> Logically, there is a mismatch because the kernel missed
>> detection on HW configurations, and we should fix it, right?
>> Do we need more detailed information?
>
> No, the above sentence is more than enough and the fix looks
> nice. Note that this sentence is more useful to users than the
> rest of the changelog combined!

Please check attached.

Thanks

Yinghai

Download attachment "wang_hp_x2apic.patch" of type "application/octet-stream" (2707 bytes)