linux-kernel - RE: [PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <076f01cdfea7$8e752d90$ab5f88b0$@samsung.com>
Date:	Tue, 29 Jan 2013 21:06:22 -0800
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Vivek Gautam' <gautam.vivek@...sung.com>,
	linux-samsung-soc@...r.kernel.org
Cc:	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, grant.likely@...retlab.ca,
	dianders@...omium.org, balbi@...com, thomas.abraham@...aro.org,
	sylvester.nawrocki@...il.com, tomasz.figa@...il.com,
	p.paneri@...sung.com
Subject: RE: [PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver

Vivek Gautam wrote:
> 
> Adding usbphy node for Exynos5250 along with the
> necessary device data to be parsed.
> 
> Signed-off-by: Vivek Gautam <gautam.vivek@...sung.com>
> ---
>  arch/arm/boot/dts/exynos5250.dtsi |   15 +++++++++++++++
>  1 files changed, 15 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 30485de..610e338 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -275,6 +275,21 @@
>  		#size-cells = <0>;
>  	};
> 
> +	usbphy@...30000 {

Please put above node by order of address.

> +		compatible = "samsung,exynos5250-usbphy";
> +		reg = <0x12130000 0x100>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		usbphy-sys {
> +			      /* USB device and host PHY_CONTROL registers
*/

Please add the binding documentation instead of comment here.

> +			reg = <0x10040704 0x8>,
> +			      /* USB2.0 PHY configuration register */
> +			      <0x10050230 0x4>;
> +		};
> +	};
> +
>  	amba {
>  		#address-cells = <1>;
>  		#size-cells = <1>;
> --
> 1.7.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/