linux-kernel - Re: [PATCH] n_tty: Unthrottle tty when flushing read buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130130043654.GA30002@kroah.com>
Date:	Tue, 29 Jan 2013 23:36:54 -0500
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Ilya Zykov <ilya@...x.ru>
Cc:	Karthik Manamcheri <Karthik.Manamcheri@...com>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andrew McGregor <andrew.mcgregor@...iedtelesis.co.nz>
Subject: Re: [PATCH] n_tty: Unthrottle tty when flushing read buffer

On Tue, Jan 29, 2013 at 02:17:26AM +0400, Ilya Zykov wrote:
> On 24.01.2013 2:36, Karthik Manamcheri wrote:
> > When the tty input buffer is full and thereby throttled,
> > flushing/resetting the read buffer should unthrottle to allow more
> > data to be received.
> > 
> > Signed-off-by: Karthik Manamcheri <Karthik.Manamcheri@...com>
> > ---
> >  drivers/tty/n_tty.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
> > index 19083efa2314660b25e0fb5bc793af6fb7e9af57..d5cea3bb01eaeec61b577de6c58a8000412c0c37 100644
> > --- a/drivers/tty/n_tty.c
> > +++ b/drivers/tty/n_tty.c
> > @@ -229,6 +229,8 @@ static void reset_buffer_flags(struct tty_struct *tty)
> >  	ldata->canon_head = ldata->canon_data = ldata->erasing = 0;
> >  	bitmap_zero(ldata->read_flags, N_TTY_BUF_SIZE);
> >  	n_tty_set_room(tty);
> > +
> > +	check_unthrottle(tty);
> >  }
> >  
> >  /**
> > 
> 
> It's revert - tty: fix "IRQ45: nobody cared".
> commit 7b292b4bf9a9d6098440d85616d6ca4c608b8304
> 
> Please, read these for this subject:
> https://lkml.org/lkml/2012/11/27/440
> https://lkml.org/lkml/2012/11/21/568
> 
> https://lkml.org/lkml/2012/11/22/686
> 
> It's already fixed in the:
> commit a1bf9584429d61b7096f93ae09325e1ba538e9e8
> tty: Add driver unthrottle in ioctl(...,TCFLSH,..).

Sorry about that, I'll go revert this now, my fault.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/