linux-kernel - Re: [PATCH v4 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130130082034.GF15258@arwen.pp.htv.fi>
Date:	Wed, 30 Jan 2013 10:20:34 +0200
From:	Felipe Balbi <balbi@...com>
To:	Kukjin Kim <kgene.kim@...sung.com>
CC:	"'Vivek Gautam'" <gautam.vivek@...sung.com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<devicetree-discuss@...ts.ozlabs.org>,
	<linux-samsung-soc@...r.kernel.org>, <gregkh@...uxfoundation.org>,
	<balbi@...com>, <grant.likely@...retlab.ca>,
	<sylvester.nawrocki@...il.com>, <tomasz.figa@...il.com>,
	<av.tikhomirov@...sung.com>, <dianders@...omium.org>,
	<p.paneri@...sung.com>
Subject: Re: [PATCH v4 2/2] usb: phy: samsung: Add PHY support for USB 3.0
 controller

On Tue, Jan 29, 2013 at 10:01:52PM -0800, Kukjin Kim wrote:
> Vivek Gautam wrote:
> > 
> > Adding PHY driver support for USB 3.0 controller for Samsung's
> > SoCs.
> > 
> > Signed-off-by: Vivek Gautam <gautam.vivek@...sung.com>
> > ---
> > 
> > Changes from v3:
> >  - Making SAMSUNG_USB3PHY dependent on SAMSUNG_USBPHY.
> >  - Adding USB_DWC3 to dependencies of SAMSUNG_USB2PHY since
> >    dwc3 controller also looks for USB2 type PHY.
> > 
> >  drivers/usb/phy/Kconfig          |   11 +-
> >  drivers/usb/phy/Makefile         |    1 +
> >  drivers/usb/phy/samsung-usb3.c   |  349
> > ++++++++++++++++++++++++++++++++++++++
> >  drivers/usb/phy/samsung-usbphy.h |   81 +++++++++
> >  4 files changed, 441 insertions(+), 1 deletions(-)
> >  create mode 100644 drivers/usb/phy/samsung-usb3.c
> > 
> > diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> > index cc0d230..9325a95 100644
> > --- a/drivers/usb/phy/Kconfig
> > +++ b/drivers/usb/phy/Kconfig
> > @@ -52,14 +52,23 @@ config SAMSUNG_USBPHY
> >  	help
> >  	  Enable this to support Samsung USB phy controllers for Samsung
> >  	  SoCs.
> > +	  Further enable USB 2.0 type PHY or USB 3.0 type PHY as required
> > +	  for USB controllers in use.
> > 
> >  if SAMSUNG_USBPHY
> > 
> >  config SAMSUNG_USB2PHY
> >  	bool "Samsung USB 2.0 PHY controller Driver"
> > -	depends on USB_S3C_HSOTG || USB_EHCI_S5P ||
> > USB_OHCI_EXYNOS
> > +	depends on USB_S3C_HSOTG || USB_EHCI_S5P ||
> > USB_OHCI_EXYNOS || USB_DWC3
> >  	help
> >  	  Enable this to support Samsung USB 2.0 (High Speed) phy controller
> >  	  for Samsung SoCs.
> > 
> > +config SAMSUNG_USB3PHY
> > +	bool "Samsung USB 3.0 PHY controller Driver"
> > +	depends on USB_DWC3
> > +	help
> > +	  Enable this to support Samsung USB 3.0 (Super Speed) phy
> > controller
> > +	  for samsung SoCs.
> > +
> >  endif
> 
> It mean, when USB_DWC3 is selected, we can select only one USB2PHY or
> USB3PHY?

right, not sure that's a wise idea. It makes enabling USB support
trickier than it needs to be. How about just dropping all dependencies
if it compiles cleanly on all arches ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)