linux-kernel - Re: [PATCH] cpsw: Fix interrupt storm among other things

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3DE2C638-6AE8-4BC9-AD68-3AAA40CD6233@antoniou-consulting.com>
Date:	Wed, 30 Jan 2013 10:36:07 +0200
From:	Pantelis Antoniou <panto@...oniou-consulting.com>
To:	Mugunthan V N <mugunthanvnm@...com>
Cc:	Richard Cochran <richardcochran@...il.com>,
	Matt Porter <mporter@...com>,
	Chase Maupin <chase.maupin@...com>, Jason Kridner <jdk@...com>,
	Tony Lindgren <tony@...mide.com>, <linux-omap@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpsw: Fix interrupt storm among other things

Hi Mugunthan,

On Jan 29, 2013, at 1:45 PM, Mugunthan V N wrote:

> On 1/28/2013 6:41 PM, Pantelis Antoniou wrote:
>> Fix interrupt storm on bone A4 cause by non-by-the-book interrupt handling.
>> While at it, added a non-NAPI mode (which is easier to debug), plus
>> some general fixes.
>> 
>> Signed-off-by: Pantelis Antoniou <panto@...oniou-consulting.com>
>> ---
>>  Documentation/devicetree/bindings/net/cpsw.txt |   1 +
>>  drivers/net/ethernet/ti/cpsw.c                 | 222 +++++++++++++++++++++----
>>  drivers/net/ethernet/ti/davinci_cpdma.c        |   4 +-
>>  drivers/net/ethernet/ti/davinci_cpdma.h        |   2 +-
>>  include/linux/platform_data/cpsw.h             |   1 +
>>  5 files changed, 194 insertions(+), 36 deletions(-)
> I have tested CPSW on AM335x EVM 1.5A with flood ping and i am not
> seeing any interrupt storm.
> Can you provide more details on how to reproduce the issue.
> 

A beaglebone prototype with the new silicon version, with the ethernet errata
fixed displays this. You can't trigger it on old silicon.

The TI people on the CC list can confirm.

> Regards
> Mugunthan V N

Regards

-- Pantelis

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/