linux-kernel - Re: [PATCH v3 40/71] ARC: OProfile support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5108FBFD.8080705@imgtec.com>
Date:	Wed, 30 Jan 2013 10:54:53 +0000
From:	James Hogan <james.hogan@...tec.com>
To:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
CC:	<linux-arch@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<arnd@...db.de>, Robert Richter <rric@...nel.org>,
	<oprofile-list@...ts.sf.net>
Subject: Re: [PATCH v3 40/71] ARC: OProfile support

On 30/01/13 06:34, Vineet Gupta wrote:
> On Tuesday 29 January 2013 10:35 PM, James Hogan wrote:
>> Hi Vineet,
>>
>> You don't appear to define CONFIG_HW_PERF_EVENTS, so
>> include/linux/oprofile.h will presumably define oprofile_perf_init as
>> just a pr_info(...); return -ENODEV;
>>
>> Similarly drivers/oprofile/oprofile_perf.o doesn't seem to be being built.
>>
>> I'm probably missing something somewhere?
> 
> Not much :-)
> 
> oprofile_arch_init() failure causes oprofile to fall back to timer based PC only
> sampling - for coarse grained profiling. I'll soon be starting on integratign the
> hardware counter support to both oprofile/perf.

Okay cool. It's just slightly misleading for anybody copying the code
that it calls oprofile_perf_init which is known never to do anything
:-). Maybe it's worth adding a comment in there to clarify. If it's only
temporary I'm fine with it.

Reviewed-by: James Hogan <james.hogan@...tec.com>

Cheers
James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/